Fixed lint errors (#491)
Lint is complaining about the new launcher icons in 'res/mipmap-anydpi-v26' are not in PNG format. These are now defined in XML and lint is probably not aware of the new XML format for API v26 and higher. This also fixes usage of "android:layout_marginEnd". Which is only supported from API v17. Added running lintFullRelease to travis-CI build.
This commit is contained in:
parent
8daa342c94
commit
b0e6d329f3
|
@ -27,4 +27,4 @@ android:
|
||||||
before_script:
|
before_script:
|
||||||
|
|
||||||
script:
|
script:
|
||||||
- ./gradlew testFullDebugUnitTest assembleFullRelease
|
- ./gradlew lintFullRelease testFullDebugUnitTest assembleFullRelease
|
||||||
|
|
|
@ -83,9 +83,10 @@ android {
|
||||||
// Too much trouble keeping all translations in sync
|
// Too much trouble keeping all translations in sync
|
||||||
disable 'MissingTranslation'
|
disable 'MissingTranslation'
|
||||||
|
|
||||||
// okio generates a lint error which should be ignored. Demote it to warning
|
//The xml launcher icon introduced in API 26 causes lint to generate
|
||||||
// See https://github.com/square/okio/issues/58
|
//an error that the icon is not a PNG format
|
||||||
warning 'InvalidPackage'
|
//This reduces the error to a warning
|
||||||
|
warning 'IconLauncherFormat'
|
||||||
}
|
}
|
||||||
|
|
||||||
// allprojects {
|
// allprojects {
|
||||||
|
|
|
@ -259,6 +259,7 @@ public class TVShowProgressFragment extends AbstractAdditionalInfoFragment imple
|
||||||
*
|
*
|
||||||
* @param cursor Cursor with the data
|
* @param cursor Cursor with the data
|
||||||
*/
|
*/
|
||||||
|
@TargetApi(21)
|
||||||
private void displaySeasonList(Cursor cursor) {
|
private void displaySeasonList(Cursor cursor) {
|
||||||
TextView seasonsListTitle = (TextView) getActivity().findViewById(R.id.seasons_title);
|
TextView seasonsListTitle = (TextView) getActivity().findViewById(R.id.seasons_title);
|
||||||
GridLayout seasonsList = (GridLayout) getActivity().findViewById(R.id.seasons_list);
|
GridLayout seasonsList = (GridLayout) getActivity().findViewById(R.id.seasons_list);
|
||||||
|
|
|
@ -4,7 +4,6 @@
|
||||||
<item name="android:layout_width">@dimen/remote_size</item>
|
<item name="android:layout_width">@dimen/remote_size</item>
|
||||||
<item name="android:layout_height">@dimen/remote_size</item>
|
<item name="android:layout_height">@dimen/remote_size</item>
|
||||||
<item name="android:layout_marginRight">@dimen/remote_content_hmargin</item>
|
<item name="android:layout_marginRight">@dimen/remote_content_hmargin</item>
|
||||||
<item name="android:layout_marginEnd">@dimen/remote_content_hmargin</item>
|
|
||||||
</style>
|
</style>
|
||||||
|
|
||||||
<style name="ControlPad">
|
<style name="ControlPad">
|
||||||
|
|
Loading…
Reference in New Issue