Refactored MusicListFragment and PVRListFragment to use AbstractTabsFragment
Fixed scrolling in a nested scroll view using espresso
Fixed issue with setting and checking Kodi major version
When a silent sync is running the refresh animation shouldn't appear and this wasn't being repected in some situations. For instance, when not connected to Kodi, starting from a TV Show details, selecting one episode or season and hitting back, the animation would appear. This PR makes sure that it is only shown if it isn't silent.
As detailed in https://github.com/xbmc/xbmc/pull/13051, Kodi v18 changes the way album genres are handled, as the genre (by which i mean `genreId`) ceases to be available at the album level, being only available at the songs level.
This impacts Kore because `GetAlbums` and `GetAlbumDetails` won't return the `genreId` tag, from which the local AlbumGenres table was populated.
This PR changes the source of the local AlbumGenres table to be the `genreId` returned at the song level (by `GetSongs`), to make it somewhat more consistent with the way Kodi will handle things from now on.
* Implemented a new widget "fabspeeddial"
* Provides user with two options to play the media item. One
option to play the item on Kodi, one to play it on the remote.
* Replaced deprecated FAB button from
com.melnykov:floatingactionbutton:1.3.0 with the FAB button from
the design library
* Implemented a busy indicator (pulsate) when fab button is clicked
and JSON API method is still pending
* Added a setting to allow the user to disable local playback and
revert back to the old behaviour
* Refactored AbstractFragmentInfo
* Replaced RelativeLayout by CoordinatorLayout to support
hiding/showing the FAB button when scrolling
* Replaced the tree view observer to fade out art view when scrolling
with a behavior for the CoordinaterLayout
* Removed empty theme file for v19
* Refactored HostConnection to allow new activities to attach its
callbacks to any pending ApiMethod. This is required to support device
configuration changes.
There's no need to have so many classes to handle the hardware volume keys. This PR simplifies it, without duplicating any more code than was already duplicated.
- added method to HostConnection that returns a Future object instead of
taking a callback.
- added logic for handling null Handlers in HostConnection methods
- added method to HostManager to run a function that takes a HostConnection
in a background thread where the Future API results above can be
synchronously composed.
- replaced chain of callbacks in RemoteActivity with a sequence of
future gets in OpenSharedUrl.
Whan the background service is launcher, it is launched on the foreground and a notification is always shown.
The service stays on while something is playing. It stops itself on a connection error, quitting Kodi or 5 seconds after stopping
Make the Pause Phone Calls preference dependent on the Show Notification preference, as we always need to show a notification when the service is running
Lint is complaining about the new launcher icons in 'res/mipmap-anydpi-v26'
are not in PNG format. These are now defined in XML and lint is probably
not aware of the new XML format for API v26 and higher.
This also fixes usage of "android:layout_marginEnd". Which is only
supported from API v17.
Added running lintFullRelease to travis-CI build.
* Refactored RemoteFragment and created a compound view for the
actual remote. I called it ControlPad to make it more clear what
its main function is.
* Implemented a custom grid layout (SquareGridLayout) that will
always be square. When its width and height are both set to
match_parent, it will take the smallest of the two as the
actual size.
* For devices with a smallest width smaller then 360dp the ControlPad
is sized to the maximum available space. For larger devices we still
use the old fixed sizes.
Refactored code to use styles
* Implemented simple Kodi markup code applier for the Now Playing fragment
* Moved to UIUtils; added early exit; now handles nesting of the same type
* Added handlers for LOWERCASE, CAPITALIZE, LIGHT and COLOR
- LOWERCASE and CAPITALIZE work, LIGHT and COLOR are just stripped out
- inlined the TextAppearanceSpan new's. Turns out they can't be reused.
* updated javadoc
* fixed crash when capitalizing an empty word
* Fixed issue with selecting tabs
* Fixed issue with switching host on other thread than UI thread
* Fixed concurrent modification exception in JSONConnectionHandlerManager
* Fixed issue with drawer not closing
* Fixes issue with running method only supported on API 21 and higher
* Allow the RemoteActivity and BaseMediaActivity to show a volume controller dialog when hardware volume keys are pressed
** The dialog handles the key events and makes callbacks to the activities to handle showing the dialog itself
* Minor improvements
** Make HighlightButton render in the IDE GUI Editor
** Minor code cleanup
** set currentActivePlayerId = -1; on playerOnStop in BaseMediaActivity to be more consistent
resolvesxbmc/Kore#235
* Refactored RemoteFragment and created a compound view for the
actual remote. I called it ControlPad to make it more clear what
its main function is.
* Implemented a custom grid layout (SquareGridLayout) that will
always be square. When its width and height are both set to
match_parent, it will take the smallest of the two as the
actual size.
* For devices with a smallest width smaller then 360dp the ControlPad
is sized to the maximum available space. For larger devices we still
use the old fixed sizes.
* The slideup panel is only displayed when something is
playing. It starts collapsed showing the media poster
and title of what is currently playing.
* Media controls implemented are volume, progress, shuffle,
repeat and play/pause for all items. Next and previous are only
available when a music item is playing.
* In collapsed mode the panel will display the mute button only
if Kodi is muted. The mute button in expanded mode is always
visible.
* Panel is enabled by default. Users can disable the panel
in Settings
* Implemented listening to Player.OnPropertyChanged notifications
to update shuffle and repeat button states.
* Sort file lists by path and show filename/foldername in details
* rewrite diplay of file lists using java.io.File for platform independence. It also makes the code clearer by avoiding string acrobatics
* fix enqueue order of action_play_from_this_item
* remove java.io.File dependency again
instead add method getFilenameFromPath
* move playMediaFile to end of block
* BaseMediaActivity enforces a common layout which allows us to more
easily add new common UI elements
* All activities that allow browsing media should extend BaseMediaActivity
Currently CastActivity is the only exception.
This introduces the MVC model to details fragments. It moves as much
view and control code out of the concrete fragments into the abstract
classes.
* Added UML class and sequence diagrams under doc/diagrams to clarify
the new setup
* Introduces new abstract classes
* AbstractFragment class to hold the DataHolder
* AbstractInfoFragment class to display media information
* AbstractAddtionalInfoFragment class to allow *InfoFragments
to add additional UI elements and propagate refresh requests.
See for an example TVShowInfoFragment which adds
TVShowProgressFragment to display next episodes and season
progression.
* Introduces new RefreshItem class to encapsulate all refresh
functionality from AbstractDetailsFragment
* Introduces new SharedElementTransition utility class to encapsulate
all shared element transition code
* Introduces new CastFragment class to encapsulate all code for
displaying casts reducing code duplication
* Introduces DataHolder class to replace passing the ViewHolder from
the *ListFragment to the *DetailsFragment or *InfoFragment
* Refactored AbstractDetailsFragment into two classes:
o AbstractDetailsFragment: for fragments requiring a tab bar
o AbstractInfoFragment: for fragments showing media information
We used to use <NAME>DetailsFragments for both fragments that show
generic
info about some media item and fragments that hold all details for
some media item.
For example, artist details showed artist info and used tabs to
show artist albums and songs as well. Now Details fragments are
used to show all details, Info fragments only show media item
information like description, title, rating, etc.
* Moved swiperefreshlayout code from AbstractCursorListFragment to
AbstractListFragment
* Add support for sharing SVTplay urls to "Play on Kodi".
SVTplay is a free streaming service provided by the Swedish national television SVT.
This feature requires the svtplay video plugin on Kodi.
* Fix SVTplay share always playing first episode of series.
* Allow specifying HTTPS Hosts manually
This is not exposed in the UI, but on the manual host configuration screen, if the address starts with a "http://" or "https://" this will be stripped and the `isHttps` flag set appropriately.
Additionally, the port can be configured as part of the address as well.
Any port specified as part of the address takes precedence over the explicit HTTP port box, to allow easy copy-pasting of an entire URL for a host.
This enables using Kore with Kodi instances available though HTTPS (e.g. via a reverse proxy).
* Changed platform AlertDialogs and preference.* to support lib counterparts
- added dependencies: support/preference-v7 for PreferenceFragmentCompat
and Preference subclasses, support/preference-v14 for the
MultiSelectListPreference
- simplified some AlertDialog.Builder calls and added non-null annotations
to DialogFragment#onCreateDialog(Bundle) overrides to shut the IDE up
- UIUtils: changed static member avatarColorsIdx to local var because it's
only used in one place and the value isn't cached
- layout/dialog_send_text: removed view vertical margins as they take
way too much space for nothing.
- strings: shortened english preference titles
- themes: added PrefTheme and changed preference title font size to medium
from large
- preferences: changed CheckBoxPreference to SwitchPreferenceCompat. these
don't have the same issue described in #233 (tested in kitkat).
* Changed platform PreferenceManager in RemoteActivity to support pref
* Fixed M permissions
* Split prefs into 2 groups as per material design guidelines
* Changed prefs theme to v14.material
* Moved container padding to individual prefs; removed pref-v7 dependency
- this makes the item dividers touch the screen edges which i think looks
better
- don't need to require preference-v7 because preference-v14 already
does
* Moved PrefTheme attributes *{Start,End} to v17 override
* Fixed crash caused by rotating twice while a dialog is active
* Changed wording as suggested
Martijn Brekhof
Synced Synapse
Mon Zafra
Tamás Varga
tomerf
Ahmed I. Khalil
Sebastian
Wikinaut
primaeval
Joel Hedlund
Aneesh Agrawal