From b01e3c8ddc38350922726bd64b032357793daeac Mon Sep 17 00:00:00 2001 From: Martijn Brekhof Date: Mon, 19 Dec 2016 19:57:08 +0100 Subject: [PATCH] Fixes reported crashes caused by a NullPointerException (#325) Multiple NullPointerExceptions have been reported in Google Play (dev). Probably caused by calling onTaskRemoved more than once. --- .../kore/service/ConnectionObserversManagerService.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/xbmc/kore/service/ConnectionObserversManagerService.java b/app/src/main/java/org/xbmc/kore/service/ConnectionObserversManagerService.java index 11b91fd..131e9b1 100644 --- a/app/src/main/java/org/xbmc/kore/service/ConnectionObserversManagerService.java +++ b/app/src/main/java/org/xbmc/kore/service/ConnectionObserversManagerService.java @@ -127,8 +127,10 @@ public class ConnectionObserversManagerService extends Service @Override public void onTaskRemoved (Intent rootIntent) { // Gracefully stop - for (HostConnectionObserver.PlayerEventsObserver observer : mConnectionObservers) { - observer.playerOnConnectionError(0, "Task removed"); + if (mConnectionObservers != null) { + for (HostConnectionObserver.PlayerEventsObserver observer : mConnectionObservers) { + observer.playerOnConnectionError(0, "Task removed"); + } } LogUtils.LOGD(TAG, "Shutting down observer service - Task removed");