From 2aa4f93aeb673a6227c12a1e2ca7d1be8be08413 Mon Sep 17 00:00:00 2001 From: Martijn Brekhof Date: Tue, 5 Dec 2017 10:58:55 +0100 Subject: [PATCH] Refactored AbstractFragment to not depend on AbstractInfoFragment (#487) Due to a previous refactoring, dataHolder was still of type AbstractInfoFragment.DataHolder which should be just DataHolder in AbstractFragment. Although AbstractInfoFragment inherits from AbstractFragment the code works. However, on KitKat (4.4) some devices reported a missing method which might be caused by this "weird" inheriting. Hopefully this fixes that. --- app/src/main/java/org/xbmc/kore/ui/AbstractFragment.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/org/xbmc/kore/ui/AbstractFragment.java b/app/src/main/java/org/xbmc/kore/ui/AbstractFragment.java index a13713a..d3b8fa7 100644 --- a/app/src/main/java/org/xbmc/kore/ui/AbstractFragment.java +++ b/app/src/main/java/org/xbmc/kore/ui/AbstractFragment.java @@ -22,9 +22,9 @@ import android.support.v4.app.Fragment; public class AbstractFragment extends Fragment { - private AbstractInfoFragment.DataHolder dataHolder; + private DataHolder dataHolder; - public void setDataHolder(AbstractInfoFragment.DataHolder dataHolder) { + public void setDataHolder(DataHolder dataHolder) { this.dataHolder = dataHolder; Bundle bundle = getArguments(); if (bundle == null) { @@ -34,7 +34,7 @@ public class AbstractFragment extends Fragment { } } - public AbstractInfoFragment.DataHolder getDataHolder() { + public DataHolder getDataHolder() { return dataHolder; } @@ -43,7 +43,7 @@ public class AbstractFragment extends Fragment { super.onCreate(savedInstanceState); if( this.dataHolder == null ) { - this.dataHolder = new AbstractInfoFragment.DataHolder(-1); + this.dataHolder = new DataHolder(-1); } this.dataHolder.setBundle(getArguments());