SecT0uch
/
Kore
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Disabled shared element transitions from API 27 (#494) 

AdapterView is not supported by the transition framework. This
became an issue with the release of API 27. In Android 8.1 the
shared element view is removed from the exiting fragment. This
causes Android to call the removeView method from AdapterView
which is not implemented and causes the app to crash.

We can reenable shared element transitions for API 27 and up by
refactoring the GridView usage to RecycleView.
This commit is contained in:
Martijn Brekhof 2017-12-22 19:21:45 +01:00 committed by Synced Synapse
parent b0e6d329f3
commit 250c1f0fd1
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/src/main/java/org/xbmc/kore/ui/BaseMediaActivity.java
View File

@ -145,7 +145,7 @@ public abstract class BaseMediaActivity extends BaseActivity
if (fragment == null) {
fragment = createFragment();
if (Utils.isLollipopOrLater()) {
if (Utils.isLollipopAndPreOreo()) {
fragment.setExitTransition(null);
fragment.setReenterTransition(TransitionInflater
.from(this)
@ -158,7 +158,7 @@ public abstract class BaseMediaActivity extends BaseActivity
.commit();
}
if (Utils.isLollipopOrLater()) {
if (Utils.isLollipopAndPreOreo()) {
sharedElementTransition.setupExitTransition(this, fragment);
}
@ -280,7 +280,7 @@ public abstract class BaseMediaActivity extends BaseActivity
FragmentTransaction fragTrans = getSupportFragmentManager().beginTransaction();
// Set up transitions
if (Utils.isLollipopOrLater()) {
if (Utils.isLollipopAndPreOreo()) {
dataHolder.setPosterTransitionName(sharedImageView.getTransitionName());
sharedElementTransition.setupEnterTransition(this, fragTrans, fragment, sharedImageView);
} else {

5
app/src/main/java/org/xbmc/kore/utils/Utils.java
View File

@ -69,6 +69,11 @@ public class Utils {
return Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP;
}
public static boolean isLollipopAndPreOreo() {
return (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) &&
(Build.VERSION.SDK_INT < 27);
}
/**
* Concats a list of strings...
* @param list